FIXME from the code#344

Locked

rfreis started this conversation inGeneral

Aug 16, 2023

· 13 comments

Discussion options

rfreis
Aug 16, 2023

Hi. Congratulations for your job done!

Just looking at the repository and as I'm working and understanding the same issue of this line comment

Line 336 in7a90811

# FIXME: How to calculate this properly? See https://docs.uniswap.org/reference/libraries/SqrtPriceMath

q96=2**96defprice_to_sqrtp(p):"""    Code from https://uniswapv3book.com/docs/milestone_1/calculating-liquidity/    """returnint(math.sqrt(p)*q96)

You must be logged in to vote

Comment options

Could you make a PR with this change? :)

On Thu, Aug 17, 2023, 09:55 Xaks ***@***.***> wrote: thx — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKXDORGK5NV4B4UIDAQSE3XVXE5XANCNFSM6AAAAAA3RZON44> . You are receiving this because you are subscribed to this thread.Message ID: <uniswap-python/uniswap-python/repo-discussions/344/comments/6748426@ github.com>