- Notifications
You must be signed in to change notification settings - Fork386
make_trade for v3 sends to 0x0 recipient#120
ToposFinance started this conversation inGeneral
-
hello, when you drill down to the final function that is called when ETH is first token, it seems you have hardcoated in a recipient address. |
BetaWas this translation helpful?Give feedback.
All reactions
Replies: 1 comment 1 reply
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
Holy shit, no idea how I could let this slip! Thanks for letting me know! Fixed in371eb84 Also published a new release (0.5.2) to PyPI which contains the fix. |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1
1 reply
-
thanks. it was an expensive lesson for me...;) |
BetaWas this translation helpful?Give feedback.
All reactions
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment