Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rewrote the Project for better support and possibilities.#71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bosunski wants to merge39 commits intounicodeveloper:master
base:master
Choose a base branch
Loading
frombosunski:lp

Conversation

bosunski
Copy link

@bosunskibosunski commentedFeb 20, 2019
edited
Loading

I really like the simplicity of paystack and of course laravel and this package is a bridge between them. I found out I kept adding lots of changes to the package when I see fit so I decided to have a major rewrite for it. Maybe from there, it can open more possibility for it.
Looking at it, this is a Major change in the project maybe it should be taggedv2.0 or something.

😁Let's go straight to the point!

Summary Of changes

  • Added Lumen Support
  • Added more tests, hence better code coverage
  • Code structure and architecture improvements
  • ALL PAYSTACK API is now covered thanks toxeviant/paystack package
  • Removed collection of data tightly coupled over Laravel Request class - meaning data can now be passed as array arguments
  • Switched toHTTPlug instead of Guzzle
  • Started work on Cache support
  • Decoupled package to include a Manager and a Factory
  • Improved Code Style
  • Disabled support for PHP 5.*
  • Add a trait to allow Request injection if you still want to pass data over laravel request.
  • Multi-connection Support for multi-tenant apps or in environments where you need to switch between Live and Test environments quickly.
  • Package Discovery now works swiftly
  • Ported old methods whilst maintaining Facade access for the meaning we still have Backward compatibility.
  • Now depends onxeviant/paystack package which provides it all of paystack.

Testing Instruction

To test this in a Laravel Project, while it's not merged, do this:

  • Add this to yourcomposer.json
"require": {"unicodeveloper/laravel-paystack":"dev-lp",    },"repositories": [        {"type":"vcs","url":"http://github.com/bosunski/laravel-paystack"        }    ],
  • Then run:
$ composer update

It will install this PR and then you can run:

php artisan vendor:publish

In the prompt choose option for Unicodeveloper\Paystack\PaystackServiceProvider

And then you can continue normal configuration and test.

Dancer-Thank-You

shalvah, Douglasokolaa, and paulfruitful reacted with thumbs up emojiaeadedoyin and elishaukpong reacted with hooray emoji
@bosunski
Copy link
Author

@unicodeveloper Awaiting Review.

@shalvah
Copy link

shalvah commentedFeb 21, 2019
edited
Loading

@bosunski As a maintainer of a popular package, I can tell you it's not likely this PR will get reviewed. It's time-consuming work with a lot of mental overhead, and my guess is@unicodeveloper doesn't make use of this package himself anymore. I suggest you message him and ask him to make you a maintainer, so you can have merge and release rights. Then you can do ahead to revamp and improve the package as you'd like.

bosunski and christopherokonkwo reacted with thumbs up emoji

@bosunski
Copy link
Author

Thanks,@shalvah.
I tried to DM on twitter though, its closed for now.

@unicodeveloper
Copy link
Owner

Thanks for the PR@bosunski. This is a lot of changes 😄

I'd try to take a look at it over the weekend.

bosunski, aeadedoyin, ichtrojan, and webong reacted with thumbs up emoji

@aeadedoyin
Copy link

@bosunski 👏 Nice! Great stuff!
Especially that easy swap between test and live mode.
Tempted to use yours pending when Uncle P reviews and possibly merge.

@bosunski
Copy link
Author

@unicodeveloper still waiting on you.

aeadedoyin reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@bosunski@shalvah@unicodeveloper@aeadedoyin

[8]ページ先頭

©2009-2025 Movatter.jp