- Notifications
You must be signed in to change notification settings - Fork32
Removecompiler-builtins fromrustc-dep-of-std dependencies#77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Since [1], this will come automatically from `rustc-std-workspace-core`and the crates.io dependency should no longer be specified.[1]:rust-lang/rust#141993
3ba2cf2 to1677322Compare@Manishearth oncerust-lang/rust#141993 lands, would it be possible to merge this PR and do a patch release reasonably quick? Once that lands there will be a bit of a race between crates that depend on |
Sure |
rust-borsbot added a commit to rust-lang/rust that referenced this pull requestJun 5, 2025
Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets. The remaining cover the rest:- `dlmalloc` (wasm, xous, sgx)alexcrichton/dlmalloc-rs#50- `gimli` (xous)- `r-efi`, `r-efi-alloc` (efi)- `fortanix-sgx-abi` (sgx)- `hermit-abi` (hermit)- `wasi` (wasi)try-job: dist-x86_64-linuxtry-job: x86_64-gnutry-job: x86_64-gnu-auxtry-job: test-various
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJun 8, 2025
…jorn3Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: dist-x86_64-linuxtry-job: x86_64-gnutry-job: x86_64-gnu-auxtry-job: test-various
rust-borsbot added a commit to rust-lang/rust that referenced this pull requestJun 8, 2025
Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: dist-x86_64-linuxtry-job: x86_64-gnutry-job: x86_64-gnu-auxtry-job: test-varioustry-job: `*android*`
bors added a commit to rust-lang/rust that referenced this pull requestJun 8, 2025
Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: dist-x86_64-linuxtry-job: x86_64-gnutry-job: x86_64-gnu-auxtry-job: test-various
rust-borsbot added a commit to rust-lang/rust that referenced this pull requestJun 8, 2025
Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: x86_64-gnutry-job: test-varioustry-job: `*various*`
rust-borsbot added a commit to rust-lang/rust that referenced this pull requestJun 9, 2025
Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: x86_64-gnutry-job: test-varioustry-job: `*various*`
tgross35 added a commit to tgross35/rust that referenced this pull requestJun 9, 2025
…jorn3Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: x86_64-gnutry-job: test-various
rust-timer added a commit to rust-lang/rust that referenced this pull requestJun 9, 2025
Rollup merge of#141993 - tgross35:use-in-tree-builtins, r=bjorn3Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: x86_64-gnutry-job: test-various
The relevant PR merged so this should be ready to go. |
tgross35 added a commit to tgross35/compiler-builtins that referenced this pull requestJun 9, 2025
Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: x86_64-gnutry-job: test-various
6db0c14 intounicode-rs:master 3 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Published |
Thank you! |
github-actionsbot pushed a commit to rust-lang/miri that referenced this pull requestJun 10, 2025
Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: x86_64-gnutry-job: test-various
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull requestJun 17, 2025
…jorn3Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: x86_64-gnutry-job: test-various
antoyo pushed a commit to rust-lang/rustc_codegen_gcc that referenced this pull requestJun 28, 2025
Use the in-tree `compiler-builtins` for the sysrootMany of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead.`compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future.Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336)Once this merges, the following PRs will need to make it to a release for the relevant crates:-rust-lang/getopts#119 (can merge at any time)-rust-lang/hashbrown#625 (can merge at any time)-rust-lang/stdarch#1825-rust-lang/rustc-demangle#80-rust-lang/cfg-if#84-unicode-rs/unicode-width#77The above should cover all tier 1 targets with no `std` features enabled. The remaining cover the rest:-alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)-gimli-rs/gimli#769-r-efi/r-efi#89 (efi)-r-efi/r-efi-alloc#9 (efi)-fortanix/rust-sgx#770 (sgx)-hermit-os/hermit-rs#718 (hermit)-bytecodealliance/wasi-rs#108 (wasi)-gimli-rs/addr2line#345-oyvindln/adler2#2-BurntSushi/memchr#180-Frommi/miniz_oxide#173-gimli-rs/object#777try-job: x86_64-gnutry-job: test-various
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Since1, this will come automatically from
rustc-std-workspace-coreand the crates.io dependency should no longer be specified.