- Notifications
You must be signed in to change notification settings - Fork32
Assign width 1 to control characters#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+547 −565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Manishearth approved these changesMay 9, 2024
Closed
andyyu2004 added a commit to andyyu2004/zi that referenced this pull requestJun 7, 2024
Seeunicode-rs/unicode-width#55 and related PRunicode-rs/unicode-width#45.It's unclear exactly where the root cause is, in ratatui or somewhere here. Will just pin the dependency and keep an eye out for now.
Aetf added a commit to Aetf/unicode-truncate that referenced this pull requestJun 24, 2024
This is consistent with how unicode-width handles string width vs charwidth.See alsounicode-rs/unicode-width#45
Aetf added a commit to Aetf/unicode-truncate that referenced this pull requestJun 24, 2024
This is consistent with how unicode-width handles string width vs charwidth.See alsounicode-rs/unicode-width#45
Aetf added a commit to Aetf/unicode-truncate that referenced this pull requestJun 24, 2024
This is consistent with how unicode-width handles string width vs charwidth.See alsounicode-rs/unicode-width#45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unicodesays the following:
In addition, U+2028 LINE SEPARATOR and U+2029 PARAGRAPH SEPARATOR are assigned width 1, which is inconsistent with assigning width 0 to
\n.The single-character width functions continue to return
Nonefor control characters (and now do so for\0as well). The sequence\r\nis assigned total width 1.