- Notifications
You must be signed in to change notification settings - Fork32
Add more canonical equivalence tests#42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Manishearth merged 8 commits intounicode-rs:masterfromJules-Bertholet:more-normalization-testsApr 30, 2024
Merged
Add more canonical equivalence tests#42
Manishearth merged 8 commits intounicode-rs:masterfromJules-Bertholet:more-normalization-testsApr 30, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Test that all canonically equivalent sequencesin Unicode's `NormalizationTest.txt` have the same width.Currently no changes need to be made to the width logicto ensure these tests pass. However, Unicode 16is adding a few new characters that will be problematic(the Kirat Rai vowel signs:<https://www.unicode.org/charts/PDF/Unicode-16.0/U160-16D40.pdf>).Adding this test in advance ensures that we won't forgetto account for these changes when the time comes.
The new test subsumes it
Ensures CI will keep passing until we choose to update
Manishearth requested changesApr 29, 2024
tests/tests.rs Outdated
| letmut nfd =String::new(); | ||
| unicode_normalization::char::decompose_canonical(c, |d| nfd.push(d)); | ||
| let norm_file =BufReader::new( | ||
| File::open("scripts/NormalizationTest.txt") |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
issue: I'd prefer to check in the file if it's used in tests.
Manishearth approved these changesApr 30, 2024
Member
Manishearth commentedApr 30, 2024
CI fails |
Manishearth approved these changesApr 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that all canonically equivalent sequences in Unicode's
NormalizationTest.txthave the same width.Currently no changes need to be made to the width logic to ensure these tests pass. However, Unicode 16 is adding a few new characters that will be problematic (the Kirat Rai vowel signs:https://www.unicode.org/charts/PDF/Unicode-16.0/U160-16D40.pdf). Adding this test in advance ensures that we won't forget to account for these changes when the time comes.