Update to Unicode 11#68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Manishearth merged 6 commits intomasterfromunicode-11

Oct 30, 2019

Merged

Update to Unicode 11#68

Manishearth merged 6 commits intomasterfromunicode-11

Oct 30, 2019

Conversation

Copy link

Member

Manishearth commentedOct 23, 2019

Hopefully after this the update to Unicode 12 will be straightforward

r?@kwantam or@mbrubeck

Copy link

MemberAuthor

Manishearth commentedOct 23, 2019

Travis will fail because of#66

Copy link

Member

kwantam commentedOct 23, 2019

@Manishearth I will try to make time to review this tomorrow.

Copy link

MemberAuthor

Manishearth commentedOct 23, 2019 via email

Thank you so much! Let me know if you have any questions.

…

On Tue, Oct 22, 2019, 7:17 PM Riad S. Wahby ***@***.***> wrote:@Manishearth <https://github.com/Manishearth> I will try to make time to review this tomorrow. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68?email_source=notifications&email_token=AAMK6SGPRP7J6HYSSGHXKDTQP6X3ZA5CNFSM4JD2E4HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7ZSZQ#issuecomment-545233254>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMK6SHGIFCY7D4JKPRAQSLQP6X3ZANCNFSM4JD2E4HA> .

Copy link

MemberAuthor

Manishearth commentedOct 23, 2019 via email

cc@zbraniecki once this PR (and an easy follow-up for unicode 12) landthis crate should be a viable option again for the unified rust icu effortsOn Tue, Oct 22, 2019, 7:17 PM Manish Goregaokar <manishsmail@gmail.com>wrote:

…

Thank you so much! Let me know if you have any questions. On Tue, Oct 22, 2019, 7:17 PM Riad S. Wahby ***@***.***> wrote:>@Manishearth <https://github.com/Manishearth> I will try to make time to> review this tomorrow.>> —> You are receiving this because you were mentioned.> Reply to this email directly, view it on GitHub> <#68?email_source=notifications&email_token=AAMK6SGPRP7J6HYSSGHXKDTQP6X3ZA5CNFSM4JD2E4HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7ZSZQ#issuecomment-545233254>,> or unsubscribe> <https://github.com/notifications/unsubscribe-auth/AAMK6SHGIFCY7D4JKPRAQSLQP6X3ZANCNFSM4JD2E4HA>> .>

Copy link

Member

kwantam commentedOct 25, 2019•
edited
Loading

~~Sorry, obviously I haven't gotten here yet. I hope to have some time in the next two days.~~

Copy link

Member

kwantam commentedOct 25, 2019

Actually, just did have some time to take a quick look, and to me things look fine and appear to correctly implement the new rules.

But it might still be useful to get a second set of eyes on this (@mbrubeck ?), because my UAX#29 recollection is slightly rusty at this point (no pun intended), so I could have missed something.