- Notifications
You must be signed in to change notification settings - Fork61
Upgrade to Unicode 10#56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+1,276 −1,216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Closed
Generates locally too. Thanks! Would you like to look into upgrading to Unicode 11? 12 is a simple data upgrade from there. |
I might look into it at some point in the future, but probably not right now. That why I thought that upgrading to 10.0 could be a start.. |
Oops forgot to merge this Thanks! |
No worries, I forgot I made it. Thanks for reviewing! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses#43 by first upgrading to Unicode 10.0 (from 9.0).
As mentioned in that issue,
which is what I have done here.
Fromhttp://www.unicode.org/versions/Unicode10.0.0/ release notes,
So no code changes are necessary as these modifications are included in the updated tables data, if I understand it right ?