Fix patterns of provide_context gets panicked#37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Manishearth merged 1 commit intounicode-rs:masterfromjmuk:fix_panic

Mar 19, 2018

Merged

Fix patterns of provide_context gets panicked#37

Manishearth merged 1 commit intounicode-rs:masterfromjmuk:fix_panic

Mar 19, 2018

Conversation

Copy link

Contributor

jmuk commentedMar 13, 2018

This PR fixes two cases where provide_context panics even though the previous call ofis_boundary returns a PreContext error.

The primary cause isprovide_context assumes its state as Regional or Emoji; otherwise it gets panicked with 'invalid state!'
However:

if the chunk starts with the cursor position, it requires pre-context forcat_before regardless of its state (and that's necessary for some cases indeed). so provide_context should fillcat_before in such case.
if bothcat_before andcat_after are RIS and the boundary is undecided by the chunk, it requires pre-context but it does not set its state to Regional. This is done by setting state withinhandle_regional.

Fix patterns of provide_context gets panicked

41a0253

This PR fixes two cases where provide_context panics even thoughthe previous call of `is_boundary` returns a PreContext error.The primary cause is `provide_context` assumes its state asRegional or Emoji; otherwise it gets panicked with 'invalid state!'However:- if the chunk starts with the cursor position, it requires  pre-context for `cat_before` (and that's necessary for some  cases indeed). so provide_context should fill `cat_before`  in such case.- if both `cat_before` and `cat_after` are RIS and the boundary  is undecided by the chunk, it requires pre-context but it does  not set its state to Regional. This is done by setting state  within `handle_regional`.