- Notifications
You must be signed in to change notification settings - Fork61
Modify benchmarks to compare against stdlib functions#133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This commit refactors and expands the microbenchmarks in order toevaluate the performance hit of handling full unicode. It is expectedthat `unicode-segmentation`'s functions are slower since they considergraphemes, the question is just how much.- bump criterion dependency- rename benchmarks to remove unicode/grapheme relationship- move benchmarks into benchmark group- add scalar versions with stdlib "equivalents" (scalars)
Results on M1 Pro:
|
Manishearth approved these changesApr 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors and expands the microbenchmarks in order to evaluate the performance hit of handling full unicode. It is expected that
unicode-segmentation
's functions are slower since they consider graphemes, the question is just how much.