- Notifications
You must be signed in to change notification settings - Fork65
Fixup package#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fixup package#123
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Cargo.toml Outdated
| """ | ||
| exclude = ["target/*","Cargo.lock","scripts/tmp","benches/texts/*","*.txt",] | ||
| exclude = ["/.github","/scripts","/benches/texts"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd rather not excludescripts, it's not used by the Rust package but people vendoring the crate sometimes care about having files like this. Can this be reverted to excludingscripts/tmp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ahh ok, that's unfortunate, the main motivation for the change was to remove executable scripts, but I'll revert that part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What's the reason for removing executable scripts? In general I'm 100% sympathetic to the idea that one shouldn't ship unnecessary executables (and I'm aware of the recent kerfuffle in the broader community), but in this case (1) they're scripts, so they're easy to inspect and compare against the git history, and (2) they are not, to my knowledge, executed automatically under any circumstances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Jake-Shadle if they have an executable bit set I do not mind removing that, but it's not a huge deal. They are scripts, not binaries.
Uh oh!
There was an error while loading.Please reload this page.
Manishearth commentedSep 6, 2023
Thanks! |
This fixes up the
package.excludefield to be simpler and actually exclude everything that is unused for downstream users, notably the entirety of thescriptsfolder. Thetarget/*andCargo.lockvalues were superfluous since they are already present in the .gitignore which cargo excludes by default.While I was doing this I noticed that github CI was now used, but the .travis.yml file was still in the root, and the README still used the travis badge, so fixed that.