- Notifications
You must be signed in to change notification settings - Fork5
Add mixed-script detection#6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
crlf0710 commentedJan 1, 2020
Seems diverted a little from the original specification since there's no handling of the Zyyy and Zinh. (Maybe that's intentional, then maybe document it a little?) And maybe you want to bikeshed a little on the module name Otherwise looks good to me. |
Manishearth commentedJan 1, 2020
@crlf0710 Zyyy and Zinh are already handled by the unicode-script crate. I'll leave a comment Heh, I realized I should rename it and did so before seeing your comment. I've also moved the identifier status stuff into its own similarly-named module. I don't have strong opinions about the name. |
Manishearth commentedJan 1, 2020
Actually, no, I hadn't gotten the Zyyy/Zinh stuffexactly right. I'll fix |
Yes, I'm using a git dependency right now, because the crate name is taken, but I have push access to the old crate and would rather just update it (seeservo/unicode-script#6)
For prototyping this should be fine.
We should also move identifier profile stuff into a different module as well.
r?@crlf0710