- Notifications
You must be signed in to change notification settings - Fork5
Fix internalSkeleton#31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This test fails due to the code currently not removingcharacters with the Default_Ignorable_Code_Point property.
Manishearth approved these changesFeb 24, 2025
eb9d304 intounicode-rs:master 3 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Member
Manishearth commentedFeb 24, 2025
Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going over UTS #39 I noticed that the
internalSkeletonfunction is defined as:But in the current implementation, we leave out step 2 which probably does not change the behaviour in most cases. Still, it is likely a good idea to fix this.
This pull request adds this step.
Notes:
load_propertiesinunicode.pyto effectively remove a copy of the function.