Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix internalSkeleton#31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ohhithere
Copy link
Contributor

While going over UTS #39 I noticed that theinternalSkeleton function is defined as:

  1. Convert X to NFD format, as described in UAX15.
  2. Remove any characters in X that have the property Default_Ignorable_Code_Point.
  3. Concatenate the prototypes for each character in X according to the specified data, producing a string of exemplar characters.
  4. Reapply NFD.

But in the current implementation, we leave out step 2 which probably does not change the behaviour in most cases. Still, it is likely a good idea to fix this.

This pull request adds this step.

Notes:

  • I took the liberty to refactorload_properties inunicode.py to effectively remove a copy of the function.
  • I regenerated the tables as is. There seem to have been some changes to the IDENTIFIER_TYPE table upstream which are included here in addition to the new table.

@ManishearthManishearth merged commiteb9d304 intounicode-rs:masterFeb 24, 2025
3 checks passed
@Manishearth
Copy link
Member

Thanks!

@ohhithereohhithere deleted the fix-internal-skeleton branchFebruary 24, 2025 20:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ManishearthManishearthManishearth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ohhithere@Manishearth

[8]ページ先頭

©2009-2025 Movatter.jp