Movatterモバイル変換

Skip to content

unicode-rs/unicode-securityPublic

NotificationsYou must be signed in to change notification settings
Fork5
Star15

Change file download urls to pull from https#24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Manishearth merged 1 commit intounicode-rs:masterfrommrluc:patch-1

Nov 22, 2021

Merged

Change file download urls to pull from https#24

Manishearth merged 1 commit intounicode-rs:masterfrommrluc:patch-1

Nov 22, 2021

Conversation

@mrluc

Copy link

Contributor

mrluc commentedNov 21, 2021

I was reading this over to understand how rust uses the unicode data files, and how rust handles these sort of unicode security issues, and I noticed that when it downloads the source files, the urls it's curling aren't https:

unicode-security/scripts/unicode.py

Lines 46 to 64 inf42826a

	# Download a Unicode security table file
	deffetch(f):
	ifnotos.path.exists(os.path.basename(f)):
	os.system("curl -O http://www.unicode.org/Public/security/%s/%s"
	% (UNICODE_VERSION_NUMBER,f))

	ifnotos.path.exists(os.path.basename(f)):
	sys.stderr.write("cannot load %s\n"%f)
	exit(1)

	# Download a UCD table file
	deffetch_unidata(f):
	ifnotos.path.exists(os.path.basename(f)):
	os.system("curl -O http://www.unicode.org/Public/%s/ucd/%s"
	% (UNICODE_VERSION_NUMBER,f))

	ifnotos.path.exists(os.path.basename(f)):
	sys.stderr.write("cannot load %s"%f)
	exit(1)

Of course this is in a script that runs pre-commit, and for that + likely many other reasons that I'm ignorant of, this PR may not be needed.

Btw thanks for all you're doing in this repo/crate. This code + its comments are the only thing that's helping me see how one can go from 'tc39 provided files' to 'prevent/warn of naughtiness in source code'. 🙏

@mrluc

http -> https 2x in py script

7f7b26e

Manishearth

Manishearth approved these changes

View reviewed changes

@mrluc

mrluc mentioned this pull request

Fix one instance of non-https curlunicode-rs/unicode-script#12

Merged

@Manishearth

Manishearth merged commit1a8846e intounicode-rs:master

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

2 participants

@mrluc

@Manishearth

[8]ページ先頭

©2009-2025 Movatter.jp