- Notifications
You must be signed in to change notification settings - Fork5
Add Display impl for AugmentedScriptSet#21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
crlf0710 commentedJun 24, 2020
Fixed a small typo and added a unit test. Do we want to use comma to separate the items here, or use the plus mentioned in #72770 ? |
Collaborator
crlf0710 commentedJun 24, 2020
By the way, I'm also a little tempted to use "Chinese" instead of "Han with Bopomofo" :) |
MemberAuthor
Manishearth commentedJun 24, 2020
Plus is fine too |
MemberAuthor
Manishearth commentedJun 24, 2020
I'm using the official spec name for it |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc@crlf0710