Migrate normalization tests to test/ to simplify pruning tests during shipping.#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Manishearth merged 4 commits intounicode-rs:masterfromkentfredric:attempt-4

Nov 22, 2019

Merged

Migrate normalization tests to test/ to simplify pruning tests during shipping.#48

Manishearth merged 4 commits intounicode-rs:masterfromkentfredric:attempt-4

Nov 22, 2019

Conversation

Copy link

Contributor

kentfredric commentedNov 22, 2019

Fixes:#38

kentfredric added4 commits

November 20, 2019 03:57

Move "normalization" test data and dependent tests all into tests/

fe93995

Leaves all other tests in place.Provides a #[doc(hidden)] shim for accessing/using otherwise privatemembers from tests/

Tidy up test layout

830bebf

- Unify all tests/ into a single file to reduce the number of output  targets during `cargo test`- This also avoids double-compiling the normalization_tests.rs- Move normalization_tests.rs to be a child of tests/data/ to avoid  getting compiled as a test unit, and further removing useless output  from cargo test

Only strip tests/ in Cargo.toml

9cea0c8

Leaving integrated bundled tests working.

Add travis glue to test built package too

0f4cb1e

kentfredric mentioned this pull request

Nov 22, 2019

Add "opt-out" test gating for vendors, document getting working tests#44

Closed

Copy link

ContributorAuthor

kentfredric commentedNov 22, 2019

You'd also need to update the script to generate the normalization tests file in the tests folder instead.

I haven't done this part yet, for 2 reasons:

The existing code doesn't drop these files in the right place as it is, and it has to be done manually.
The existing code generates a copy of the tables.rs file without some changes that were recently added manually:cc442c3#diff-c423bc3001a014e9b6c8d2d65fcd5da6

diff --git a/src/tables.rs b/src/tables.rsindex 960a94f..f92898d 100644--- a/src/tables.rs+++ b/src/tables.rs@@ -19217,6 +19217,7 @@ pub(crate) const COMBINING_MARK_KV: &[u32] = &[   #[inline]+#[allow(ellipsis_inclusive_range_patterns)] pub fn qc_nfc(c: char) -> IsNormalized {     match c {         '\u{0340}'...'\u{0341}' => No,@@ -19340,6 +19341,7 @@ pub fn qc_nfc(c: char) -> IsNormalized { }  #[inline]+#[allow(ellipsis_inclusive_range_patterns)] pub fn qc_nfkc(c: char) -> IsNormalized {     match c {         '\u{00A0}' => No,@@ -19776,6 +19778,7 @@ pub fn qc_nfkc(c: char) -> IsNormalized { }  #[inline]+#[allow(ellipsis_inclusive_range_patterns)] pub fn qc_nfd(c: char) -> IsNormalized {     match c {         '\u{00C0}'...'\u{00C5}' => No,@@ -20025,6 +20028,7 @@ pub fn qc_nfd(c: char) -> IsNormalized { }  #[inline]+#[allow(ellipsis_inclusive_range_patterns)] pub fn qc_nfkd(c: char) -> IsNormalized {     match c {         '\u{00A0}' => No,