- Notifications
You must be signed in to change notification settings - Fork44
Add "opt-out" test gating for vendors, document getting working tests#44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hopefully this provides the best of all worlds.Importantly, this re-introduces src/test.rs, as that's something thatcan't be trivially generated.Both approaches are documented so the path to the easiest workingsolution is clear for vendors, and they can pick either the moreexpensive solution, or the simpler (but less comprehensive) one.If this PR meets general approval, I'd like to add a .travis.ymlstep that automatically tests the --cfg minimal_tests path, so atleast, that will be a "stable" target, as testing that the deployedcrate is free from errors is presently too much work to expect theaverage maintainer or contributor to remember to do.Closes:unicode-rs#38
Manishearth commentedOct 28, 2019
I think this approach is okay. Adding the travis entry also sounds good. An alternate approach that might be better for you would be to move stuff into Up to you, both approaches seem fine to me, but the latter means that you don't need special instructions for running the tests. |
This is still just a work-in-progress, so may be rebased-out in future,just seeing if it Works yet before I spend time on something potentiallymore finely grained.
kentfredric commentedNov 22, 2019
Self closing as is subsumed by#48 |
Hopefully this provides the best of all worlds.
Importantly, this re-introduces src/test.rs, as that's something that
can't be trivially generated.
Both approaches are documented so the path to the easiest working
solution is clear for vendors, and they can pick either the more
expensive solution, or the simpler (but less comprehensive) one.
If this PR meets general approval, I'd like to add a .travis.yml
step that automatically tests the --cfg minimal_tests path, so at
least, that will be a "stable" target, as testing that the deployed
crate is free from errors is presently too much work to expect the
average maintainer or contributor to remember to do.
Closes:#38