Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update Unicode to version 16.0.0, bump to 0.1.24#103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Manishearth merged 5 commits intounicode-rs:masterfromMarcondiro:master
Sep 17, 2024

Conversation

Marcondiro
Copy link
Contributor

Yet another tables update to Unicode 16.0.0
Thanks!

@Marcondiro

This comment was marked as outdated.

@MarcondiroMarcondiroforce-pushed themaster branch 5 times, most recently fromea010a0 to4d86994CompareSeptember 13, 2024 15:25
@MarcondiroMarcondiro marked this pull request as draftSeptember 13, 2024 15:39
Copy link
Member

@ManishearthManishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's possible there are algorithm changes as well in 16.0

@Marcondiro
Copy link
ContributorAuthor

There is some issue in the nfc computation for two new characters: U+105C9 and U+105E4

@Marcondiro
Copy link
ContributorAuthor

Marcondiro commentedSep 16, 2024•
edited
Loading

Likely a bug here

defgen_composition_table(canon_comp,out):
table= {}
for (c1,c2),c3incanon_comp.items():
ifc1<0x10000andc2<0x10000:
table[(c1<<16)|c2]=c3
(salt,keys)=minimal_perfect_hash(table)
gen_mph_data('COMPOSITION_TABLE',table,'(u32, char)',
lambdak:f"(0x{k:08X}, '\\u{{{table[k]:06X}}}')",1)
out.write("pub(crate) fn composition_table_astral(c1: char, c2: char) -> Option<char> {\n")
out.write(" match (c1, c2) {\n")
for (c1,c2),c3insorted(canon_comp.items()):
ifc1>=0x10000andc2>=0x10000:
out.write(" ('\\u{%s}', '\\u{%s}') => Some('\\u{%s}'),\n"% (hexify(c1),hexify(c2),hexify(c3)))
out.write(" _ => None,\n")
out.write(" }\n")
out.write("}\n")

My hypotheses is that if(c1 < 0x10000 && c2 >= 0x10000) || (c1 > 0x10000 && c2 <= 0x10000) the entry is ignored

@MarcondiroMarcondiro marked this pull request as ready for reviewSeptember 17, 2024 12:09
@ManishearthManishearth merged commitc992130 intounicode-rs:masterSep 17, 2024
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ManishearthManishearthManishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Marcondiro@Manishearth
[8]ページ先頭
©2009-2025 Movatter.jp