uber/react-visPublic

NotificationsYou must be signed in to change notification settings
Fork832
Star8.8k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

add fontSize property to label-series#1276

Open

dandgerson wants to merge1 commit intouber:master

base:master

Choose a base branch

fromdandgerson:add-label-series-font-size

Open

add fontSize property to label-series#1276

dandgerson wants to merge1 commit intouber:masterfromdandgerson:add-label-series-font-size

Conversation

Copy link

dandgerson commentedNov 14, 2019

Thank you for amazing library. It very useful in our production.

I want to add some functional to our label-series
I have to some customize fontSize property for labels and suggest this feature.

I had this small PR as fist step. I would be glad to continue commit

Example:

<LabelSeries          animation={animation}          className={className}          rotation={labelRotation}          labelAnchorY="text-before-edge"          data={nodesCopy.map((node, i) => {            return {              x: node.x0 + (node.x0 < width / 2 ? nWidth + 10 : -10),              y: (node.y0 + node.y1) / 2 - marginTop,              label: node.name,              style: {                textAnchor: node.x0 < width / 2 ? 'start' : 'end',                dy: '-.5em',                fontSize: node.fontSize || 'inherit', // add fontSize                ...style.labels              },              // unfortunately this can not be ...node as the version              // found in nodesCopy is modified by the sankey process              ...nodes[i]            };          })}        />