- Notifications
You must be signed in to change notification settings - Fork462
Add support for Search Craft#629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
regexes.yaml Outdated
| family_replacement:'Baidu Explorer' | ||
| # Search Craft | ||
| -regex:'(SearchCraft)/(\d+)\.(\d+)\.(\d+)(?:\.(\d+)|)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you add a test for the(?:\.(\d+)|) part
907d724 tofdecbd8Compare@lbarthon Thanks for the feedback! I’ve added tests for the major.minor.patch format to ensure compatibility with cases where patch_minor is missing. |
sorry for the long delay@welkinwong - I'd like new regexes to be as low as possible in the regexes list |
fdecbd8 to4d1d264Compare4d1d264 tod96adb0Compare@lbarthon hi, Thank you for your response. I've gone ahead and updated all the relevant PRs to ensure the regexes are placed as low as possible in the list. |
Add support for Search Craft App