Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
Disambiguate numbering pattern names#6379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
If we're attempting to align names with CSS, are there any plans to also test against other implementations of CSS numbering to ensure compatibility? |
To start the discussion of how to proceed here, I will write down some points. To begin with, how could we rename/name the patterns.
I think that actually both of these options are dependent on a decision about which numbering patterns to support. Especially the second option will be achieved in the most consistent manner if there is an understanding about exactly which variations of any given numbering pattern are expected to be included. Then comes the question of how to organise the selection of these patterns.It has been mentioned that these patterns could be contained in a separate repo or crate. Is this still potential? To me this seems a bit much, but the list of css ready-made styles is very large, so perhaps this will bring some organisational benefit. |
do you have any references for this? I haven't stumbled across any apart from w3. |
emilyyyylime commentedJun 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Only thing I could think of is looking into the implementations of browser engines / rendering an html doc directly using them. If we do decide to aim for CSS compatibility as a goal I think splitting this to a separate crate/project could have value to the Rust community at large, and even to young browser engines. |
Is this true? To me it seems like this is a fairly niche area, but maybe I just haven't thought about it enough. Suppose this was split to a separate crate/repo, how would we actually go about doing that? Is this something which has happened in other areas of the codebase before? |
It definitely has. Examples includehttps://github.com/typst/unicode-math-class andhttps://github.com/typst/codex, but more generally a lot of the stuff you can see onhttps://github.com/orgs/typst/repositories.
I think we can work on the PR here first regardless of whether we decide to incorporate all CSS counter styles. If we decide to include all and want a separate repository, I would take care of setting this all up. |
Do you have any thoughts on naming convention@laurmaedje ? We can use this pr to rename the current patterns and add any others we want, since these won't be accessible before the {} is implemented anyway. |
I've involved the folks that are working on Typst symbol naming inhttps://github.com/typst/codex viaDiscord. I'm thinking that numbering systems could potentially also be moved into that crate. |
See#5622 for the discussion so far.