Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(typescript-estree): don't throw on missing tsconfig.json by default in project service#9989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Changes error throwing to only occur if the user explicitly provides aparserOptions.defaultProject.

💖

hoi4, ex0ns, cuquo, and kansson reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 14, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit318279b
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/66e59a9bf48f9d0008432618
😎 Deploy Previewhttps://deploy-preview-9989--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 14, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit318279b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedSep 14, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.67%. Comparing base(77e65df) to head(318279b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #9989   +/-   ##=======================================  Coverage   88.67%   88.67%           =======================================  Files         425      425             Lines       14797    14799    +2       Branches     4302     4304    +2     =======================================+ Hits        13121    13123    +2  Misses       1533     1533             Partials      143      143
FlagCoverage Δ
unittest88.67% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...-estree/src/create-program/createProjectService.ts95.45% <100.00%> (+0.21%)⬆️

Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@auvredauvred added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 14, 2024
@ex0ns
Copy link

I have been troubleshooting this issue on my side without realizing there was an open issue/pr to already fix that. I was checking about the fix and wondering about theif inside the try, that involve knowing the subtle difference between theconfig andoptionRawObject, it also feels a bit strange to parse the config file that might not exist and then wait for the exception.

I don't want to overstep, but I have tested the following solution (closer to what was done in 8.4)

if(options.allowDefaultProject?.length){log('Enabling default project: %s',options.defaultProject);letconfigFile:ts.ParsedCommandLine;try{configFile=getParsedConfigFile(tsserver,options.defaultProject,tsconfigRootDir,);}catch(error){thrownewError(`Could not read project service default project '${options.defaultProject}':${(errorasError).message}`,);}service.setCompilerOptionsForInferredProjects(// NOTE: The inferred projects API is not intended for source files when a tsconfig// exists.  There is no API that generates an InferredProjectCompilerOptions suggesting// it is meant for hard coded options passed in. Hard asserting as a work around.// See https://github.com/microsoft/TypeScript/blob/27bcd4cb5a98bce46c9cdd749752703ead021a4b/src/server/protocol.ts#L1904configFile.optionsasts.server.protocol.InferredProjectCompilerOptions,);}

Which will only try to parse the config if we actually want to use a defaultProject.

@JoshuaKGoldbergJoshuaKGoldberg merged commitef3384e intotypescript-eslint:mainSep 15, 2024
65 of 66 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@auvredauvredauvred approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Upgrade to 8.5.0 breaks linting setup with NX andprojectService: true
4 participants
@JoshuaKGoldberg@ex0ns@bradzacher@auvred

[8]ページ先頭

©2009-2025 Movatter.jp