Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-misused-promises] check array predicate return#9955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromyeonjuan:imp/1038
Sep 16, 2024

Conversation

yeonjuan
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 9, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit9f161d4
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/66e737a35005350008fa2bb8
😎 Deploy Previewhttps://deploy-preview-9955--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 9, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9f161d4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedSep 9, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base(ef3384e) to head(9f161d4).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #9955      +/-   ##==========================================+ Coverage   88.67%   88.69%   +0.01%==========================================  Files         425      426       +1       Lines       14799    14820      +21       Branches     4304     4310       +6     ==========================================+ Hits        13123    13144      +21  Misses       1533     1533                Partials      143      143
FlagCoverage Δ
unittest88.69% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts98.81% <100.00%> (+0.03%)⬆️
...slint-plugin/src/rules/no-unnecessary-condition.ts99.51% <100.00%> (-0.01%)⬇️
...-plugin/src/util/isArrayMethodCallWithPredicate.ts100.00% <100.00%> (ø)

Comment on lines 25 to 26
node.callee.property.type === AST_NODE_TYPES.Identifier &&
ARRAY_PREDICATE_FUNCTIONS.has(node.callee.property.name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
node.callee.property.type===AST_NODE_TYPES.Identifier&&
ARRAY_PREDICATE_FUNCTIONS.has(node.callee.property.name)
ARRAY_PREDICATE_FUNCTIONS.has(getStaticMemberAccessValue(node.callee))

[Refactor] Now that#9836 is already merged, we can use a nice utility function for this!

yeonjuan reacted with thumbs up emoji
Comment on lines 30 to 32
return tsutils
.typeParts(type)
.some(t => checker.isArrayType(t) || checker.isTupleType(t));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Bug] I think we should useunionTypeParts andintersectionTypeParts here, because the rule doesn't report on this code:

declareconstarray:(string[]&{foo:'bar'})|(number[]&{bar:'foo'})array.every(()=>Promise.resolve(true));

playground

yeonjuan reacted with thumbs up emoji
@auvredauvred added the awaiting responseIssues waiting for a reply from the OP or another party labelSep 14, 2024
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelSep 15, 2024
@yeonjuan
Copy link
ContributorAuthor

@auvred Thanks 👍9f161d4

Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool!

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love being reminded about the array hardcodings 😄

@JoshuaKGoldbergJoshuaKGoldberg merged commit454d37e intotypescript-eslint:mainSep 16, 2024
63 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@auvredauvredauvred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: [no-misused-promises] 'checksConditionals' should check array predicate return
3 participants
@yeonjuan@JoshuaKGoldberg@auvred
[8]ページ先頭
©2009-2025 Movatter.jp