Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: inject option descriptions into rule docs when possible#9925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

For each rule whosemeta.schema[0] is an object withtype: "properties" ortype: "oneOf", this adds thedescription for each of those option properties to the rule's docs page.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedSep 3, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit693d24c
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6709464c534bcd0007276150
😎 Deploy Previewhttps://deploy-preview-9925--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedSep 3, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit693d24c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewSeptember 20, 2024 15:20
@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamSeptember 20, 2024 15:23
@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelOct 10, 2024
@codecovCodecov
Copy link

codecovbot commentedOct 11, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.09%. Comparing base(ef5df2f) to head(693d24c).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #9925   +/-   ##=======================================  Coverage   86.09%   86.09%           =======================================  Files         428      428             Lines       14969    14969             Branches     4343     4343           =======================================  Hits        12888    12888             Misses       1734     1734             Partials      347      347
FlagCoverage Δ
unittest86.09% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...t-plugin/src/rules/class-literal-property-style.ts100.00% <ø> (ø)
.../eslint-plugin/src/rules/class-methods-use-this.ts91.30% <ø> (ø)
...lugin/src/rules/consistent-generic-constructors.ts90.24% <ø> (ø)
...lugin/src/rules/consistent-indexed-object-style.ts96.61% <ø> (ø)
...nt-plugin/src/rules/consistent-type-definitions.ts100.00% <ø> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts97.61% <ø> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts97.82% <ø> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts97.66% <ø> (ø)
...s/eslint-plugin/src/rules/no-restricted-imports.ts94.87% <ø> (ø)
...ges/eslint-plugin/src/rules/no-restricted-types.ts93.02% <ø> (ø)
... and5 more

@JoshuaKGoldbergJoshuaKGoldberg removed the awaiting responseIssues waiting for a reply from the OP or another party labelOct 11, 2024
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm happy with this approach!

JoshuaKGoldberg reacted with hooray emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitd09d36d intotypescript-eslint:mainOct 15, 2024
61 of 62 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 24, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Automatically inject rule option descriptions into their docs
2 participants
@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp