I read the comments on the issue, and it seemed better to create a new option rather than adding a function to ignoreConditionalTests, so I created a new option.

The reason is that I thought it was reasonable to say that there is no case in typescript-eslint where the content raised in the issue is judged as a condition/boolean.

feat: make new option

aa7545b

Copy link

Contributor

typescript-eslintbot commentedSep 3, 2024

Thanks for the PR,@developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 3, 2024•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

Name	Link
🔨 Latest commit	`52c3596`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6725acfab9448f0008c7480a

Copy link

nx-cloudbot commentedSep 3, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit52c3596. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

fix: test error

029f64e

Copy link

codecovbot commentedSep 4, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is88.57143% with4 lines in your changes missing coverage. Please review.

Project coverage is 86.51%. Comparing base(099fd4c) to head(52c3596).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	88.57%	4 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main    #9924      +/-   ##==========================================- Coverage   86.51%   86.51%   -0.01%==========================================  Files         430      430                Lines       15098    15123      +25       Branches     4384     4400      +16     ==========================================+ Hits        13062    13083      +21- Misses       1679     1683       +4  Partials      357      357

Flag	Coverage Δ
unittest	`86.51% <88.57%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`95.51% <88.57%> (-2.20%)`	⬇️

fix: lint error

ce4df82

JoshuaKGoldberg reviewed

Sep 30, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts Outdated

		(current.type === AST_NODE_TYPES.CallExpression &&
		current.callee.type === AST_NODE_TYPES.Identifier &&
		// eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
		current.callee.name === 'Boolean')

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Bug] Folks sometimes write their ownfunction Boolean( ... ) { ... }. This rule will need to handle that well.

Previous example:#10005 (comment)

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thank you. I modified it by referring to the code written by@yeonjuan .

JoshuaKGoldberg reviewed

Sep 30, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts Outdated

		* `if (() => a \|\| b) {}`
		* `if (function () { return a \|\| b }) {}`
		*/
		return false;

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Testing] Good to see that the cases tripping this up are known 😄.

Also to test are other unusual things inifs:

class expressions
new expressions
Function decorators
...I'm drawing a blank on more spooky things at the moment, but there's a good chance more exist.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Because I was copying the isConditionalTest function, I forgot to change the example case. In practice, an example would beBoolean(()=> a || b).
Therefore, it seems that the situations you mentioned should actually apply to the isConditionalTest function as well. Should the work be done in this pr?
Actually, I did not exactly understand the three cases you mentioned. Could you please give an example if possible?
The additional case I was considering is an object. Should cases likeBoolean({test:a||b}) also be included?

JoshuaKGoldberg requested changes

Sep 30, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey sorry for the long wait! This is a good start, but I think has some edge case handling and testing to go. 🚀

packages/eslint-plugin/docs/rules/prefer-nullish-coalescing.mdx Outdated

		@@ -172,6 +172,34 @@ foo ?? 'a string';

		Also, if you would like to ignore all primitives types, you can set `ignorePrimitives: true`. It is equivalent to `ignorePrimitives: { string: true, number: true, bigint: true, boolean: true }`.

		### `ignoreMakeBoolean`

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Docs]"make" is a general word. Let's go withignoreBooleanCoercion:

Suggested change

	###`ignoreMakeBoolean`
	###`ignoreBooleanCoercion`

packages/eslint-plugin/docs/rules/prefer-nullish-coalescing.mdx Outdated

Comment on lines 177 to 179

		Whether to ignore any make boolean type value like `Boolan`, `!` .

		like !, Boolean, etc. You can use this when you do not want to apply the rule to cases that make the value a boolean.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	Whether to ignore any make boolean type value like`Boolan`,`!` .

	like !, Boolean, etc. You can use this when you do not want to apply the rule to cases that make the value a boolean.
	Whether to ignore expressions that coerce a value into a boolean:`Boolean(...)` and`!(...)`.

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Sep 30, 2024

fix: apply code review

9e11e22

developer-bandi requested a review fromJoshuaKGoldberg

October 3, 2024 14:53

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 3, 2024

kirkwaiblinger requested changes

Oct 9, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why does this option include allowing arguments to the! operator? The discussion in the issue explicitly contradicts this#9080 (comment)

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts OutdatedShow resolvedHide resolved

kirkwaiblinger added the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 9, 2024

Copy link

ContributorAuthor

developer-bandi commentedOct 10, 2024

이 옵션에!연산자에 대한 인수 허용이 포함되는 이유는 무엇입니까? 이 이슈의 논의는 이#9080(코멘트) 과 명백히 모순됩니다.

This is clearly my mistake.

I misunderstood that the Not operator should be included in the process of understanding the context.

I will remove all related code and test code.

developer-bandi added2 commits

October 10, 2024 22:03

fix: typo correction

15ac922

fix: remove not operator logic

723d0a8

developer-bandi requested a review fromkirkwaiblinger

October 10, 2024 13:40

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 10, 2024

kirkwaiblinger requested changes

Oct 10, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts Outdated

Comment on lines 451 to 466

		function isMakeBoolean(
		node: TSESTree.Node,
		context: Readonly<TSESLint.RuleContext<MessageIds, Options>>,
		): boolean {
		const parents = new Set<TSESTree.Node \| null>([node]);
		let current = node.parent;
		while (current) {
		parents.add(current);

		if (
		current.type === AST_NODE_TYPES.CallExpression &&
		isBuiltInBooleanCall(current, context)
		) {
		return true;
		}

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So, the algorithm in this function definitely has some problems....

For example, the following code will be ignored by the new option

leta:string|true|undefined;letb:string|boolean|undefined;declarefunctionf(x:unknown):unknown;constx=Boolean(f(a||b));

However, I'm also noticing that the existing code works quite similarly....

typescript-eslint/packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

Lines 414 to 449 in723d0a8

	functionisConditionalTest(node:TSESTree.Node):boolean{
	constparents=newSet<TSESTree.Node\|null>([node]);
	letcurrent=node.parent;
	while(current){
	parents.add(current);

	if(
	(current.type===AST_NODE_TYPES.ConditionalExpression\|\|
	current.type===AST_NODE_TYPES.DoWhileStatement\|\|
	current.type===AST_NODE_TYPES.IfStatement\|\|
	current.type===AST_NODE_TYPES.ForStatement\|\|
	current.type===AST_NODE_TYPES.WhileStatement)&&
	parents.has(current.test)
	){
	returntrue;
	}

	if(
	[
	AST_NODE_TYPES.ArrowFunctionExpression,
	AST_NODE_TYPES.FunctionExpression,
	].includes(current.type)
	){
	/**
	* This is a weird situation like:
	* `if (() => a \|\| b) {}`
	* `if (function () { return a \|\| b }) {}`
	*/
	returnfalse;
	}

	current=current.parent;
	}

	returnfalse;
	}

So I'm wondering whether that has bugs too....

Without that context, I'd think we'd want to model this algorithm closer to what's in other rules, for example, no-floating-promises or no-extra-boolean-cast. Those rules recurse specifically on logical expressions,?? expressions, ternaries, chain expressions, sequence expressions.

Copy link

ContributorAuthor

developer-bandiOct 14, 2024•
edited by kirkwaiblinger
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

upon checking, it appears that similar code is ignored when the ignoreConditionalTests option is trueplayground

declareleta:string|null;declareconstb:string|null;declarefunctionf(x:unknown):unknown;if(f(a||b)){}while(f(a||b)){}

so i think isConditionalTest function need to modified. Would it be a good idea to open a new issue for this problem?

to modify algorithm, I looked at theno-extra-boolean-cast code you mentioned.

considering what you mentioned, it seems like you can improve it by referring to the algorithm of the function below, but I am wondering if my understanding is correct.

https://github.com/eslint/eslint/blob/main/lib/rules/no-extra-boolean-cast.js#L117-L167

Copy link

Member

kirkwaiblingerOct 14, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What fun, haha. Thanks for checking on this!

I think file an issue no matter what, and it's up to you if you feel motivated and want to fix it in this PR or prefer to not worry about it in this work. 👍

Copy link

Member

kirkwaiblingerOct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

considering what you mentioned, it seems like you can improve it by referring to the algorithm of the function below, but I am wondering if my understanding is correct.

Yeah, exactly, that's the pattern I'm suggesting to study 👍 (just the first thing that came to my mind, sinceI have previously touched that code)

Copy link

ContributorAuthor

developer-bandiOct 15, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What fun, haha. Thanks for checking on this!
I think file an issue no matter what, and it's up to you if you feel motivated and want to fix it in this PR or
prefer to not worry about it in this work. 👍

It is assumed that similar logic will be used in isConditionalTest Fn, so �i will work on it together in this PR.

Copy link

ContributorAuthor

developer-bandiOct 15, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

considering what you mentioned, it seems like you can improve it by referring to the algorithm of the function below, but I am wondering if my understanding is correct.
Yeah, exactly, that's the pattern I'm suggesting to study 👍 (just the first thing that came to my mind, sinceI have previously touched that code)

thank you, I will look at the code in more detail and then proceed with the work.

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 10, 2024

fix: apply code review

d5f780f

developer-bandi requested a review fromkirkwaiblinger

October 14, 2024 18:22

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 14, 2024

kirkwaiblinger mentioned this pull request

Oct 15, 2024

Bug: [prefer-nullish-coalescing] faulty detection of conditional tests withignoreConditionalTests: true#10153

Closed

4 tasks

change logical logic

a46d2af

Copy link

ContributorAuthor

developer-bandi commentedOct 20, 2024

i edit theisConditionalTest andisBooleanConstructorContext with no-extra-boolean-cast rule's code.

These functions have been modified in almost the same way, changing from recursively searching if a parent exists to recursively searching only if the logical operation conditions are satisfied.

The logical operation conditions are the same for both functions, but recursive search is allowed only when the result of the logical operation is used as the value.

recursive is not allowed

if(f(a||b))
if(()=>a||b)
if((a||b)?.[c])
....

**recursive is allowed **

if (a || (b && c)) {}
if (a ?? (b || c)) {}
...

For more examples, please refer to the test code.

kirkwaiblinger changed the title~~feat(eslint-plugin): [prefer-nullish-coalescing] make ignore Boolean like option~~feat(eslint-plugin): [prefer-nullish-coalescing] add optionignoreBooleanCoercion

Oct 20, 2024

kirkwaiblinger reviewed

Oct 21, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts OutdatedShow resolvedHide resolved

refactor: fix isBooleanConstructorContext and isConditionalTest fn

dfcc469

developer-bandi requested a review fromkirkwaiblinger

October 22, 2024 14:49

kirkwaiblinger previously approved these changes

Oct 23, 2024

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for going above and beyond by fixing issues in the existing code in addition to the added functionality!

kirkwaiblinger reviewed

Oct 23, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts Outdated

		@@ -103,6 +104,11 @@ export default createRule<Options, MessageIds>({
		'Whether to ignore any ternary expressions that could be simplified by using the nullish coalescing operator.',
		type: 'boolean',
		},
		ignoreBooleanCoercion: {
		description:
		'Whether to ignore any make boolean type value like `Boolean`',

Copy link

Member

kirkwaiblingerOct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	'Whether to ignoreany make boolean type value like`Boolean`',
	'Whether to ignorearguments to the`Boolean` constructor',

fix:docs{

9d8c4e4

developer-bandi dismissedkirkwaiblinger’sstale review via9d8c4e4

October 27, 2024 06:58

kirkwaiblinger added 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels

Oct 27, 2024

developer-bandi added4 commits

November 2, 2024 11:31

Merge branch 'main' ofhttps://github.com/developer-bandi/typescript-…

99df843

…eslint into feature/prefer-nullish-coalescing

fix: merge confict miss add

f59d7cc

fix: lint error

f738414

fix: snapshot update

52c3596

Copy link

ContributorAuthor

developer-bandi commentedNov 2, 2024

added commit to resolve conflicts.

kirkwaiblinger approved these changes

Nov 2, 2024

View reviewed changes

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Nov 2, 2024

bradzacher approved these changes

Nov 3, 2024

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks!

bradzacher merged commitbe3a224 intotypescript-eslint:main

Nov 3, 2024

59 of 64 checks passed

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Nov 4, 2024

fix(deps): update typescript-eslint monorepo to v8.13.0

36eca14

##### [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221))-   **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924))-   **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250))##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232))-   **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235))-   **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259))-   **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261))-   **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205))##### ❤️  Thank You-   auvred [@auvred](https://github.com/auvred)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 6, 2024

Update typescript-eslint monorepo to v8.13.0

12a50df

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.12.2 | 8.13.0 || npm        | @typescript-eslint/parser        | 8.12.2 | 8.13.0 |## [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221))-   **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924))-   **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250))##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232))-   **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235))-   **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259))-   **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261))-   **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205))##### ❤️  Thank You-   auvred [@auvred](https://github.com/auvred)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Nov 7, 2024

Update typescript-eslint monorepo to v8.13.0

486fea9

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.12.2 | 8.13.0 || npm        | @typescript-eslint/parser        | 8.12.2 | 8.13.0 |## [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221))-   **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924))-   **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250))##### 🩹 Fixes-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232))-   **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235))-   **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259))-   **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261))-   **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205))##### ❤️  Thank You-   auvred [@auvred](https://github.com/auvred)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Nov 11, 2024

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

4 participants

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [prefer-nullish-coalescing] add optionignoreBooleanCoercion#9924

feat(eslint-plugin): [prefer-nullish-coalescing] add optionignoreBooleanCoercion#9924

Uh oh!

Conversation

developer-bandi commentedSep 3, 2024• edited by kirkwaiblingerLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedSep 3, 2024

Uh oh!

netlifybot commentedSep 3, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

❌ Deploy Preview fortypescript-eslint failed.

Uh oh!

nx-cloudbot commentedSep 3, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedSep 4, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

developer-bandi commentedOct 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

developer-bandiOct 14, 2024• edited by kirkwaiblingerLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirkwaiblingerOct 14, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

developer-bandiOct 15, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

developer-bandiOct 15, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

developer-bandi commentedOct 20, 2024

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

developer-bandi commentedNov 2, 2024

Uh oh!

feat(eslint-plugin): [prefer-nullish-coalescing] add option`ignoreBooleanCoercion`#9924

feat(eslint-plugin): [prefer-nullish-coalescing] add option`ignoreBooleanCoercion`#9924

developer-bandi commentedSep 3, 2024•
edited by kirkwaiblinger
Loading

netlifybot commentedSep 3, 2024•
edited
Loading

nx-cloudbot commentedSep 3, 2024•
edited
Loading

codecovbot commentedSep 4, 2024•
edited
Loading

developer-bandiOct 14, 2024•
edited by kirkwaiblinger
Loading

kirkwaiblingerOct 14, 2024•
edited
Loading

developer-bandiOct 15, 2024•
edited
Loading

developer-bandiOct 15, 2024•
edited
Loading