Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: also test rule-tester in CI#9919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Addsrule-tester to the list of tested packages in CI.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedSep 3, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitaf13ea8
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/66d68fd2fabff20008800731
😎 Deploy Previewhttps://deploy-preview-9919--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedSep 3, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitaf13ea8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedSep 3, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base(5d9f49c) to head(af13ea8).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #9919      +/-   ##==========================================- Coverage   88.12%   86.03%   -2.09%==========================================  Files         406      425      +19       Lines       13951    14791     +840       Branches     4076     4302     +226     ==========================================+ Hits        12294    12726     +432- Misses       1344     1718     +374- Partials      313      347      +34
FlagCoverage Δ
unittest86.03% <ø> (-2.09%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 19 files with indirect coverage changes

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

how has this been missed for so long?!!?!?!?

JoshuaKGoldberg reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 3, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit7ab7f00 intotypescript-eslint:mainSep 6, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the test-rule-tester-ci branchSeptember 6, 2024 13:14
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Test rule-tester in CI

2 participants

@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp