Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: add more project service docs and FAQs#9871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedAug 23, 2024
edited
Loading

PR Checklist

Overview

Steals some of the docs from#8031 so we can get them in sooner.

Also adds in FAQs around the most common mishaps we've seen from users. Largely:

  • Questions around files not being included in their nearesttsconfig.json (e.g..js files withoutallowJs/checkJs)
  • You can't use non-tsconfig.json files as the main file path; if you're using TSConfigs to build with a separate system, building should be the custom non-tsconfig.json paths (e.g.tsconfig.build.json)

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedAug 23, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitef44301
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/66c8b08740f8fa000981c741
😎 Deploy Previewhttps://deploy-preview-9871--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedAug 23, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitef44301. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.


See [issue #2094 discussing project references](https://github.com/typescript-eslint/typescript-eslint/issues/2094) for more details.

## Project Service Issues

<HiddenHeading id="allowdefaultproject-glob-too-wide" />
<HiddenHeading id="allowdefaultprojectforfiles-glob-too-wide" />
Copy link
MemberAuthor

@JoshuaKGoldbergJoshuaKGoldbergAug 23, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This second heading is a holdover from the experimental/v7 name. I think anybody newly configuring the service should reasonably be on v8 now. Our docs don't still hold true for the old experimental way of holding the project service.

@@ -320,38 +321,49 @@ module.exports = {
This option brings two main benefits over the older `project`:

- Simpler configurations: most projects shouldn't need to explicitly configure `project` paths or create `tsconfig.eslint.json`s
- Improved performance: this API is optimized on the TypeScript side for speed
- Initial versions of this option demonstrated performance changes in subsets of the typescript-eslint monorepo ranging from 11% slower to 70% faster
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We're still working on performance & filling in the gaps on edge cases. IMO we should stop bragging about it until we can be very, very certain it's better the vast majority of the time.

kirkwaiblinger reacted with thumbs up emoji

h5 {
font-weight: bold;
}
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It was bugging me that the h5s underProjectServiceOptions were roughly the same font size & weight as the text around them...

bradzacher
bradzacher previously approved these changesAug 23, 2024
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelAug 27, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commitd9f66da intotypescript-eslint:mainAug 27, 2024
59 of 61 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the project-service-docs-and-faqs branchAugust 27, 2024 18:28
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add FAQs and flesh out associated docs for project service
2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp