Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: fill in most remaining rule option descriptions#9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedAug 23, 2024
edited
Loading

PR Checklist

Overview

Addsdescription properties to most rule options that didn't have them. This should be all remaining rules that aren't feature-frozen or using only an enum/string array (instead of object) for their options.

There are probably some rules missing that could be improved. I ran out of energy before converting most string literal union types into enums... If#9866 lands, we'll be forced to fill them in anyway.

Also standardizes the phrasing of some options to sound more like each other. Mostly, that's starting boolean options with"Whether ..." instead of some of the many more wordy ways we've used.

Another good next step after this would be#9867 IMO: using these descriptions in rule docs pages. The phrasing standardization helps with that.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedAug 23, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit93505f5
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/66c8019f37aabc0008925e78
😎 Deploy Previewhttps://deploy-preview-9868--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedAug 23, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit93505f5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg changed the titledocs: fill in most remainng rule option descriptionsdocs: fill in most remaining rule option descriptionsAug 23, 2024
@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamAugust 23, 2024 03:58
Comment on lines +48 to +52
/** The expected assertion style to enforce. */
assertionStyle:
| 'as'
/** The expected assertion style to enforce. */
| 'angle-bracket';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤮 formatting is ew sadly

JoshuaKGoldberg reacted with thumbs up emojiJoshuaKGoldberg reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelAug 23, 2024
@JoshuaKGoldbergJoshuaKGoldberg requested review fromkirkwaiblinger and removed request forkirkwaiblingerAugust 29, 2024 18:30
@JoshuaKGoldbergJoshuaKGoldberg merged commit5fd4251 intotypescript-eslint:mainAug 29, 2024
75 of 76 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the rule-option-descriptions branchAugust 29, 2024 18:31
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add descriptions to rule schema options
2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp