I particularly like the replacements of the stylea.concat(b) =>[...a, ...b] because I like thata andb are given "equal weight" visually when they are both spread into a new array, whereas withconcat one is before theconcat and one is inside theconcat and so visually they don't have "equal weight".

abrahamguo added2 commits

August 19, 2024 21:19

enable and autofix

f0a60ab

non autofixable cases

2a1f5ca

Copy link

Contributor

typescript-eslintbot commentedAug 20, 2024

Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedAug 20, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`4f4561c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66d7bbc207e5b30008fd2cba
😎 Deploy Preview	https://deploy-preview-9834--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedAug 20, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4f4561c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 29 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedAug 20, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is78.57143% with3 lines in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base(6f24fe6) to head(4f4561c).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/convert.ts	0.00%	3 Missing⚠️

Additional details and impacted files

@@           Coverage Diff           @@##             main    #9834   +/-   ##=======================================  Coverage   88.12%   88.12%           =======================================  Files         406      406             Lines       13951    13951             Branches     4076     4076           =======================================  Hits        12294    12294             Misses       1344     1344             Partials      313      313

Flag	Coverage Δ
unittest	`88.12% <78.57%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...eslint-plugin/src/rules/consistent-type-exports.ts	`95.40% <100.00%> (ø)`
...ackages/eslint-plugin/src/rules/member-ordering.ts	`96.61% <100.00%> (ø)`
packages/eslint-plugin/src/rules/no-shadow.ts	`80.45% <100.00%> (ø)`
...es/eslint-plugin/src/rules/prefer-function-type.ts	`97.10% <100.00%> (ø)`
...ackages/eslint-plugin/src/rules/prefer-readonly.ts	`97.85% <ø> (ø)`
...ages/eslint-plugin/src/rules/unified-signatures.ts	`85.62% <ø> (ø)`
packages/scope-manager/src/ScopeManager.ts	`77.64% <100.00%> (ø)`
...ee/src/create-program/createProjectProgramError.ts	`100.00% <100.00%> (ø)`
.../src/create-program/getWatchProgramsForProjects.ts	`82.85% <ø> (ø)`
packages/typescript-estree/src/getModifiers.ts	`66.66% <100.00%> (ø)`
... and5 more