Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	5a425ff
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66bc0f23758a9500075674c3
😎 Deploy Preview	https://deploy-preview-9788--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5a425ff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

Sent with 💌 fromNxCloud.

Would you mind filing an issue for this and/or fleshing out the description with the PR that this change is fixing up? The commit referenced says it's not on a branch within this repo, so it's hard to figure out what this is in reference to

Yep, sorry! This came from#9479.

I agree with@auvred, I will add some unit tests to validate this change.

Inno-redundant-type-constituents,never is not allowed in unions.
However, an exception is for function return types, where itis allowed in unions.
BecauseTSDeclareFunction was missing fromfunctionTypeTypes, the rule wronglydid report forTSDeclareFunctions but not other function types, as shown in@auvred's example:

declare function fn(): never | 'foo' // wrongly reportstype ffn = () => never | 'foo'

In this PR, it now correctly recognizesTSDeclareFunction as a function type, and now no longer reports.