typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(rule-tester): provide Linter a cwd in its constructor#9678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 6 commits intotypescript-eslint:v8fromJoshuaKGoldberg:rule-tester-direct-cwd

Jul 31, 2024

Merged

fix(rule-tester): provide Linter a cwd in its constructor#9678

JoshuaKGoldberg merged 6 commits intotypescript-eslint:v8fromJoshuaKGoldberg:rule-tester-direct-cwd

Jul 31, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedJul 30, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: v8 RuleTester crashes on ESLint >=9.5.0 #9676
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Per#9676 (comment), uses the more friendlyLintercwd constructor param instead of working around ESLint's internals.

I see this PR as finishing what#9603 started & should have finished: fully embracing the new "flat"Linter's paradigm of setting thecwd from the beginning.

💖

fix(rule-tester): provide Linter a cwd in its constructor

25230bd

Copy link

Contributor

typescript-eslintbot commentedJul 30, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

JoshuaKGoldberg mentioned this pull request

Jul 30, 2024

fix(rule-tester): support ESLint >=9.5.0's new language internal#9677

Closed

3 tasks

Copy link

netlifybot commentedJul 30, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`09c739c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66a9388ef1fbda0008af5755
😎 Deploy Preview	https://deploy-preview-9678--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJul 30, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit09c739c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.