typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(typescript-estree): factor tsconfigRootDir into allowDefaultProject#9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v8fromJoshuaKGoldberg:project-service-default-project-relative-to-tsconfig-root-dir

Jul 31, 2024

Merged

fix(typescript-estree): factor tsconfigRootDir into allowDefaultProject#9675

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v8fromJoshuaKGoldberg:project-service-default-project-relative-to-tsconfig-root-dir

Jul 31, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedJul 30, 2024

PR Checklist

Addresses an existing open issue:fixesBug: Local paths not supported by projectService's allowDefaultProject #9674
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

The"does this file's path match the allowed list of files" needed to be relative totsconfigRootDir, not the absolute path.

💖

fix(typescript-estree): factor tsconfigRootDir into allowDefaultProje…

ebc7b29

…ct paths

Copy link

Contributor

typescript-eslintbot commentedJul 30, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

JoshuaKGoldberg added this to the8.0.0 milestone

Jul 30, 2024

Copy link

netlifybot commentedJul 30, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ebc7b29`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66a8f05ad6d12200084c800d
😎 Deploy Preview	https://deploy-preview-9675--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJul 30, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitebc7b29. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedJul 30, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base(838dd0c) to head(ebc7b29).
Report is 15 commits behind head on v8.

Additional details and impacted files

@@           Coverage Diff           @@##               v8    #9675   +/-   ##=======================================  Coverage   88.05%   88.05%           =======================================  Files         402      402             Lines       13657    13658    +1       Branches     3967     3967           =======================================+ Hits        12026    12027    +1  Misses       1322     1322             Partials      309      309

Flag	Coverage Δ
unittest	`88.05% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files	Coverage Δ
...escript-estree/src/useProgramFromProjectService.ts	`100.00% <100.00%> (ø)`

JoshuaKGoldberg changed the title~~fix(typescript-estree): factor tsconfigRootDir into allowDefaultProje…~~fix(typescript-estree): factor tsconfigRootDir into allowDefaultProject

Jul 30, 2024

JoshuaKGoldberg requested a review froma team

July 30, 2024 18:06