Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(type-utils): support intersection types in TypeOrValueSpecifier#9633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJul 24, 2024•
edited
Loading

PR Checklist

Overview

ChangesspecifierNameMatches to:

  1. Always check alias names of the types, to support directly matching type aliases
  2. For intersection types, also checktype.types.some(...) recursively

Sending this to thev8 branch because it's based on someTypeOrValueSpecifier changes inv8. But it doesn't block shipping v8 and isn't a part of the v8 milestone.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJul 24, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit4b50da9
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/66a10a9e2048d60008058d85
😎 Deploy Previewhttps://deploy-preview-9633--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat(type-utils): [TypeOrValueSpecifier] support intersection typesfeat(type-utils): support intersection types in TypeOrValueSpecifierJul 24, 2024
@nx-cloud
Copy link

nx-cloudbot commentedJul 24, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4b50da9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedJul 24, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base(56ef573) to head(4b50da9).
Report is 1 commits behind head on v8.

Additional details and impacted files
@@           Coverage Diff           @@##               v8    #9633   +/-   ##=======================================  Coverage   88.01%   88.01%           =======================================  Files         401      401             Lines       13637    13639    +2       Branches     3960     3961    +1     =======================================+ Hits        12003    12005    +2  Misses       1325     1325             Partials      309      309
FlagCoverage Δ
unittest88.01% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
.../src/typeOrValueSpecifiers/specifierNameMatches.ts100.00% <100.00%> (ø)

@auvredauvred added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJul 28, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit90432a2 intotypescript-eslint:v8Jul 29, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 7, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@auvredauvredauvred approved these changes

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoshuaKGoldberg@auvred
[8]ページ先頭
©2009-2025 Movatter.jp