Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: add integration test against @types/eslint v9#9622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomainfrombjz/flat-config-types-integration-test-v9
Jul 23, 2024

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

Copy pastes the integration test so we have one for v8 types and one for v9 types.
Both passed out of the box -- the failure was instead with@stylistic/eslint-plugin's usage of ESLint's types being broken by the v9 types

@bradzacherbradzacher added the testsanything to do with testing labelJul 23, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 23, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit8cbcd17
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/669fa0e235c12f000890a6ce
😎 Deploy Previewhttps://deploy-preview-9622--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 23, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit8cbcd17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 fromNxCloud.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Swell!

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJul 23, 2024
@bradzacherbradzacher merged commite239e0c intomainJul 23, 2024
67 of 68 checks passed
@bradzacherbradzacher deleted the bjz/flat-config-types-integration-test-v9 branchJuly 23, 2024 22:24
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergetestsanything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug:@types/eslint causingflat-config-types integration test failure onmain
2 participants
@bradzacher@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp