typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

docs: switch Typed Linting docs to project service#9614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:v8fromJoshuaKGoldberg:typed-linting-docs-project-service

Jul 29, 2024

Merged

docs: switch Typed Linting docs to project service#9614

JoshuaKGoldberg merged 2 commits intotypescript-eslint:v8fromJoshuaKGoldberg:typed-linting-docs-project-service

Jul 29, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedJul 22, 2024

PR Checklist

Addresses an existing open issue:fixesDocs: Updated typed linting docs for new project service #9085
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Goes through our first-run docs to suggestparserOptions.projectService instead ofparserOptions.project.

For the FAQs files, splits intoProject Service Issues andTraditional Project Issues headings, respectively.

Does not update the parser package's docs themselves (/packages/parser#projectservice). I'm still waiting on performance investigations to know how to frame things (#9571).

💖

docs: switch Typed Linting docs to project service

88d603f

Copy link

Contributor

typescript-eslintbot commentedJul 22, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

JoshuaKGoldberg requested a review froma team

July 22, 2024 23:16

JoshuaKGoldberg added this to the8.0.0 milestone

Jul 22, 2024

Copy link

netlifybot commentedJul 22, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`11e8579`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66a00d397532ae00081028c7
😎 Deploy Preview	https://deploy-preview-9614--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJul 22, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit11e8579. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

Merge branch 'v8' into typed-linting-docs-project-service

11e8579

Copy link

codecovbot commentedJul 23, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base(f3dfc0a) to head(11e8579).
Report is 12 commits behind head on v8.

Additional details and impacted files

@@           Coverage Diff           @@##               v8    #9614   +/-   ##=======================================  Coverage   88.01%   88.01%           =======================================  Files         401      401             Lines       13637    13637             Branches     3960     3960           =======================================  Hits        12003    12003             Misses       1325     1325             Partials      309      309