Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(eslint-plugin): [return-await] add return-await to strict-type-checked preset#9604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblingerkirkwaiblinger commentedJul 22, 2024
edited
Loading

BREAKING CHANGE Technicallynot a breaking change, since it's only going to the strict config, but targeting v8 anyway to batch it in with the rest of our config changes.

PR Checklist

Overview

Nothin but a config change

Note, also, followup to#9595, thanks@JoshuaKGoldberg for the tip on the config generation infra


Co-authored-by:@JoshuaKGoldberg

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 22, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit1bf49fd
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/669df61f3d155e00088d5820
😎 Deploy Previewhttps://deploy-preview-9604--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@kirkwaiblingerkirkwaiblinger changed the base branch frommain tov8July 22, 2024 05:48
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 22, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit1bf49fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 fromNxCloud.

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 swell!

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJul 22, 2024
@kirkwaiblingerkirkwaiblinger merged commit88a8673 intotypescript-eslint:v8Jul 22, 2024
71 of 72 checks passed
@kirkwaiblingerkirkwaiblinger deleted the return-await-preset branchJuly 22, 2024 13:36
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 30, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configs: includereturn-await instrict-type-checked preset
2 participants
@kirkwaiblinger@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp