Switches the internals of our forkedRuleTester to work withnew Linter({ configType: 'flat' }); instead ofconfigType: 'eslintrc'. This is a pretty substantial breaking change internally:

this.#linter is no longer able todefineRule() ad hoc; instead, theconfig: TesterConfigWithDefaults has to haveplugins including the rule.
Because the@/ plugin can't be redefined, a@rule-tester/ prefix is added in front of rule names.
Per flat config, anyparser,parserOptions, and other language-specific settings are moved tolanguageOptions.
- This caused a lot of churn in our test files
Per flat config,parser has to be the actual parser, not a string descriptor.
- As a convenience, I formally defaulted it to our parser
- I went ahead and removed all the redundantparser: '@typescript-eslint/parser',parserOptions: { sourceType: 'module' }, and other seemingly unnecessary options from our test files
Marks the@typescript-eslint/utilsRuleTester re-export as deprecated

I think we'll want to follow this up with added info in the v8 beta blog post. See ourpackages/eslint-plugin(-internal)/**/*.test.ts file changes. There's a fair amount users will have to do:

Nestlib,parser,parserOptions,sourceType, and any other parser options insidelanguageOptions
Switchparser from astring to the actual parser
The defaultecmaVersion andsourceType are now'latest' and'module', respectively

💖

feat(rule-tester): switched to flat config

df2b832

Copy link

Contributor

typescript-eslintbot commentedJul 22, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 22, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`11c5c78`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66a0e48cf8c5db000866436b
😎 Deploy Preview	https://deploy-preview-9603--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

JoshuaKGoldberg mentioned this pull request

Jul 22, 2024

feat(rule-tester): add reimplementation of RuleTester#9331

Closed

3 tasks

JoshuaKGoldberg added this to the8.0.0 milestone

Jul 22, 2024

Copy link

nx-cloudbot commentedJul 22, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit11c5c78. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

Copy link

Member

bradzacher commentedJul 22, 2024

Per flat config, any parser and parserOptions, and other language-specific settings are moved to languageOptions.

Thought: I wonder if we should have hoisted up our stuff / the common stuff to avoid churn. Cos this will mess with all the ecosystem as well. I know that was their intent but it is going to block plugins hard.

All but one rule test passing; refreshed SourceCode method deprecatio…

12fdf84

…ns/wrappers; hacked around [] getConfig

Copy link

MemberAuthor

JoshuaKGoldberg commentedJul 22, 2024•
edited
Loading

Per flat config, any parser and parserOptions, and other language-specific settings are moved to languageOptions.
Thought: I wonder if we should have hoisted up our stuff / the common stuff to avoid churn. Cos this will mess with all the ecosystem as well. I know that was their intent but it is going to block plugins hard.

Yeah I don't think we're in a good place to do anything here. +1 that this will be work for plugins, but:

Switching ourRuleTester from a rough drop-in to something noticeably different from the core config system would be a big step away from core
Most plugins will just need to wrap some stuff inlanguageOptions

fix: don't ... spread languageOptions.parser

0296c06

JoshuaKGoldberg marked this pull request as ready for review

July 22, 2024 12:05

JoshuaKGoldberg requested review froma team andbradzacher

July 22, 2024 12:05

bradzacher approved these changes

Jul 22, 2024

View reviewed changes

packages/rule-tester/src/RuleTester.ts OutdatedShow resolvedHide resolved

bradzacher added the breaking changeThis change will require a new major version to be released label

Jul 22, 2024

JoshuaKGoldberg mentioned this pull request

Jul 23, 2024

Docs: Update v8 beta announcement post one last time#9626

Closed

2 tasks

JoshuaKGoldbergand others added2 commits

July 24, 2024 07:22

Update packages/rule-tester/src/RuleTester.ts

376c75f

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

share the require of parser

11c5c78

Copy link

codecovbot commentedJul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base(ae980e3) to head(11c5c78).
Report is 8 commits behind head on v8.

Additional details and impacted files

@@            Coverage Diff             @@##               v8    #9603      +/-   ##==========================================+ Coverage   88.00%   88.01%   +0.01%==========================================  Files         401      401                Lines       13647    13637      -10       Branches     3965     3960       -5     ==========================================- Hits        12010    12003       -7  Misses       1325     1325+ Partials      312      309       -3

Flag	Coverage Δ
unittest	`88.01% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files	Coverage Δ
packages/utils/src/eslint-utils/deepMerge.ts	`89.47% <ø> (ø)`
packages/utils/src/ts-eslint/Linter.ts	`50.00% <ø> (ø)`
packages/utils/src/ts-eslint/RuleTester.ts	`50.00% <ø> (ø)`
packages/utils/src/ts-eslint/SourceCode.ts	`50.00% <ø> (ø)`