WhenparseSettings.projects is populated,useProvidedPrograms nows refer toparserOptions.project andproject(s) instead ofparserOptions.programs andprogram(s).

Also applies a mild refactor to reduce nesting in the function.

I think after this I'd like to holistically revamp the error messages around invalid

💖

Copy link

Contributor

typescript-eslintbot commentedJul 18, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 18, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`c201b6c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/669910a32b9d5a00088032eb
😎 Deploy Preview	https://deploy-preview-9584--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

JoshuaKGoldberg commented

Jul 18, 2024

View reviewed changes

packages/typescript-estree/src/create-program/useProvidedPrograms.ts


		astAndProgram.program.getTypeChecker();// ensure parent pointers are set in source files
		constrelativeFilePath=path.relative(
		parseSettings.tsconfigRootDir,

Copy link

MemberAuthor

JoshuaKGoldbergJul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This used to betsconfigRootDir || process.cwd(), but I'm pretty sure that's unnecessary.createParseSettings already defaultstsconfigRootDir toprocess.cwd().

Copy link

nx-cloudbot commentedJul 18, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitc201b6c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx run repo-tools:postinstall-script

Sent with 💌 fromNxCloud.

JoshuaKGoldberg marked this pull request as ready for review

July 18, 2024 11:51

JoshuaKGoldberg requested a review froma team

July 18, 2024 11:51

JoshuaKGoldberg marked this pull request as draft

July 18, 2024 11:52

JoshuaKGoldberg removed the request for review froma team

July 18, 2024 11:52

fix(typescript-estree): specific error for parserOptions.project not …

b58de4b

…including a file

JoshuaKGoldberg force-pushed theproject-programs-not-found-error branch from0ac9fb4 tob58de4bCompare

July 18, 2024 11:53

Copy link

codecovbot commentedJul 18, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base(c365664) to head(c201b6c).
Report is 6 commits behind head on v8.

Additional details and impacted files

@@           Coverage Diff           @@##               v8    #9584   +/-   ##=======================================  Coverage   87.91%   87.92%           =======================================  Files         397      397             Lines       13556    13556             Branches     3936     3936           =======================================+ Hits        11918    11919    +1  Misses       1325     1325+ Partials      313      312    -1