typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

feat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8#9559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v8fromJoshuaKGoldberg:no-floating-promises-v8-check-thenables

Jul 14, 2024

Merged

feat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8#9559

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v8fromJoshuaKGoldberg:no-floating-promises-v8-check-thenables

Jul 14, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedJul 13, 2024

BREAKING CHANGE:
Changes a rule's default option.

PR Checklist

Addresses an existing open issue:fixesEnhancement: [no-floating-promises] Disable checkThenables by default in v8 #9508
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Changes the option's default fromtrue tofalse and updates docs + tests.

💖

feat(eslint-plugin): [no-floating-promises] disable checkThenables by…

d5e4c8c

… default for v8

Copy link

Contributor

typescript-eslintbot commentedJul 13, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 13, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`d5e4c8c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6692c49b86db700009741c55
😎 Deploy Preview	https://deploy-preview-9559--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

JoshuaKGoldberg mentioned this pull request

Jul 13, 2024

feat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8#9509

Closed

3 tasks

Copy link

nx-cloudbot commentedJul 13, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd5e4c8c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx run repo-tools:postinstall-script

Sent with 💌 fromNxCloud.

JoshuaKGoldberg requested a review froma team

July 13, 2024 18:18

Copy link

codecovbot commentedJul 13, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base(6bd4211) to head(d5e4c8c).

Additional details and impacted files

@@            Coverage Diff             @@##               v8    #9559      +/-   ##==========================================- Coverage   87.91%   87.90%   -0.02%==========================================  Files         397      397                Lines       13558    13558                Branches     3939     3939              ==========================================- Hits        11920    11918       -2- Misses       1324     1326       +2  Partials      314      314