Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-floating-promises] addsuggestions to tests from #9263checkThenables#9515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

abrahamguo
Copy link
Contributor

@abrahamguoabrahamguo commentedJul 8, 2024•
edited by kirkwaiblinger
Loading

PR Checklist

Overview

Addssuggestions property that was missing in tests from#9263 causing pipeline failures inmain.

kirkwaiblinger reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 8, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitd4018e8
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/668b2de6cfe665000892c07f
😎 Deploy Previewhttps://deploy-preview-9515--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 8, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd4018e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 fromNxCloud.

@abrahamguoabrahamguo changed the titlefix(eslint-plugin): [no-floating-promises] addsuggestions to tests from #9263fix(eslint-plugin): [no-floating-promises] addsuggestions to tests from #9263checkThenablesJul 8, 2024
@codecovCodecov
Copy link

codecovbot commentedJul 8, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base(3e19436) to head(d4018e8).
Report is 252 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@##           main    #9515       +/-   ##=========================================+ Coverage      0   88.37%   +88.37%=========================================  Files         0      419      +419       Lines         0    14618    +14618       Branches      0     4279     +4279     =========================================+ Hits          0    12919    +12919- Misses        0     1375     +1375- Partials      0      324      +324
FlagCoverage Δ
unittest88.37% <ø> (?)

Flags with carried forward coverage won't be shown.Click here to find out more.

see 413 files with indirect coverage changes

Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

abrahamguo reacted with hooray emoji
@kirkwaiblingerkirkwaiblinger merged commit3c6290d intotypescript-eslint:mainJul 8, 2024
76 checks passed
@JoshuaKGoldberg
Copy link
Member

Whoops, thanks!

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(eslint-plugin): [no-floating-promises] missingsuggestions property on tests from #9263checkThenables
3 participants
@abrahamguo@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp