Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8#9509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJul 6, 2024•
edited
Loading

BREAKING CHANGE:
Changes a rule's default option.

PR Checklist

Overview

Changes the option's default fromtrue tofalse and updates docs + tests.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov8July 6, 2024 19:37
@netlifyNetlify
Copy link

netlifybot commentedJul 6, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitc71bbec
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6692c40db83fef0008aa03b9
😎 Deploy Previewhttps://deploy-preview-9509--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg changed the titleNo floating promises v8 check thenablesfeat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8Jul 6, 2024
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 6, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit150fd5b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 fromNxCloud.

* fix(utils): context.parserPath may be undefined* Update packages/utils/src/eslint-utils/getParserServices.tsCo-authored-by: Brad Zacher <brad.zacher@gmail.com>---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneJul 6, 2024
abrahamguoand others added10 commitsJuly 7, 2024 23:50
…remove `fixable` from `meta` (typescript-eslint#9527)chore: remove `fixable` from `meta`No fixer is actually present.Ref:typescript-eslint#8903 (comment)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…g change PR" workflow (typescript-eslint#9533)" (typescript-eslint#9535)Revert "chore: don't install dependencies in "Semantic breaking change PR" workflow (typescript-eslint#9533)"This reverts commit0d4b098.
Co-authored-by: typescript-eslint[bot] <typescript-eslint[bot]@users.noreply.github.com>
@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamJuly 13, 2024 16:19
@Josh-Cena
Copy link
Member

Branch seems corrupted, could you rebase?

@JoshuaKGoldberg
Copy link
MemberAuthor

Huh, will fix. Sorry about that.

@JoshuaKGoldbergJoshuaKGoldbergforce-pushed theno-floating-promises-v8-check-thenables branch fromc71bbec tod5e4c8cCompareJuly 13, 2024 18:15
@JoshuaKGoldbergJoshuaKGoldberg deleted the no-floating-promises-v8-check-thenables branchJuly 13, 2024 18:16
@JoshuaKGoldbergJoshuaKGoldberg restored the no-floating-promises-v8-check-thenables branchJuly 13, 2024 18:16
@JoshuaKGoldberg
Copy link
MemberAuthor

🤷 recreated in#9559.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 21, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the no-floating-promises-v8-check-thenables branchJanuary 16, 2025 13:53
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Enhancement: [no-floating-promises] Disable checkThenables by default in v8
6 participants
@JoshuaKGoldberg@Josh-Cena@abrahamguo@y-hsgw@auvred@dasa
[8]ページ先頭
©2009-2025 Movatter.jp