Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(website): react key error on internal pages of website#9506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

y-hsgw
Copy link
Contributor

@y-hsgwy-hsgw commentedJul 6, 2024
edited
Loading

PR Checklist

Overview

It appears that the error occurred due to the presence of a key in the previous version ofLineInputProps. This issue has been resolved by updating the prism-react-renderer version.
※I determined that the impact area is limited, as prism-react-renderer is used only inpackages/website/src/theme/CodeBlock/Content/String.tsx. Therefore, I proceeded with a major update. Please advise on the appropriate flow for updating package versions if there is a recommended procedure.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 6, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit5678ddd
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/668bae4b40420c0008bce09b
😎 Deploy Previewhttps://deploy-preview-9506--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 6, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5678ddd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedJul 6, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base(3c6290d) to head(5678ddd).

Additional details and impacted files
@@           Coverage Diff           @@##             main    #9506   +/-   ##=======================================  Coverage   88.37%   88.37%           =======================================  Files         419      419             Lines       14618    14618             Branches     4279     4279           =======================================  Hits        12919    12919             Misses       1375     1375             Partials      324      324
FlagCoverage Δ
unittest88.37% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Copy link
Member

@Josh-CenaJosh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Effect LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] Always great to see a deduplication 😄 nice!

y-hsgw reacted with laugh emoji
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Confirmed this fixes it for me, and both the existing syntax highlighting and playground still work. Thanks for the cleanup! 🧹

y-hsgw reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commit03fe3db intotypescript-eslint:mainJul 8, 2024
60 of 63 checks passed
@JoshuaKGoldberg
Copy link
Member

Oh, dangit, I should have renamed this tochore: orchore(website):.#5218

@y-hsgwy-hsgw deleted the fix/website-react-key-error branchJuly 8, 2024 12:28
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@Josh-CenaJosh-CenaJosh-Cena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@y-hsgw@JoshuaKGoldberg@Josh-Cena

[8]ページ先頭

©2009-2025 Movatter.jp