Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(website): react key error on internal pages of website#9506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(website): react key error on internal pages of website#9506
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@y-hsgw! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedJul 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
nx-cloudbot commentedJul 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit5678ddd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 fromNxCloud. |
codecovbot commentedJul 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #9506 +/- ##======================================= Coverage 88.37% 88.37% ======================================= Files 419 419 Lines 14618 14618 Branches 4279 4279 ======================================= Hits 12919 12919 Misses 1375 1375 Partials 324 324
Flags with carried forward coverage won't be shown.Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Effect LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[Praise] Always great to see a deduplication 😄 nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Confirmed this fixes it for me, and both the existing syntax highlighting and playground still work. Thanks for the cleanup! 🧹
03fe3db
intotypescript-eslint:mainUh oh!
There was an error while loading.Please reload this page.
Oh, dangit, I should have renamed this to |
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Overview
It appears that the error occurred due to the presence of a key in the previous version of
LineInputProps
. This issue has been resolved by updating the prism-react-renderer version.※I determined that the impact area is limited, as prism-react-renderer is used only in
packages/website/src/theme/CodeBlock/Content/String.tsx
. Therefore, I proceeded with a major update. Please advise on the appropriate flow for updating package versions if there is a recommended procedure.