typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

fix(eslint-plugin): [restrict-template-expressions] don't report tuples if`allowArray` option is enabled#9492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromauvred:fix/9491

Jul 8, 2024

Merged

fix(eslint-plugin): [restrict-template-expressions] don't report tuples if`allowArray` option is enabled#9492

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromauvred:fix/9491

Jul 8, 2024

Conversation

Copy link

Member

auvred commentedJul 4, 2024

PR Checklist

Addresses an existing open issue:fixesBug: [restrict-template-expressions] allowArrays errors on "as const" arrays. #9491
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

fix(eslint-plugin): [restrict-template-expressions] don't report tupl…

acf626a

…es if `allowArray` option is enabled

Copy link

Contributor

typescript-eslintbot commentedJul 4, 2024

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 4, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`acf626a`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/668668628c5bc20008c3d0e1
😎 Deploy Preview	https://deploy-preview-9492--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJul 4, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitacf626a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx run repo-tools:postinstall-script

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedJul 4, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base(7e2b77d) to head(acf626a).
Report is 12 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main    #9492   +/-   ##=======================================  Coverage   88.26%   88.26%           =======================================  Files         417      417             Lines       14413    14413             Branches     4208     4208           =======================================  Hits        12721    12721             Misses       1372     1372             Partials      320      320