Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(utils): context.parserPath may be undefined#9486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

First switchesparserPath tostring | undefined, then adds in handling to try to usecontext.languageOptions.parser.meta.name if it exists.

💖

Sniper1h reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

Sniper1h reacted with thumbs up emoji

@netlifyNetlify
Copy link

netlifybot commentedJul 3, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit674cb58
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6685b7294fe0da000817d988
😎 Deploy Previewhttps://deploy-preview-9486--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Sniper1h reacted with thumbs up emoji

@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamJuly 3, 2024 18:47
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 3, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit674cb58. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedJul 3, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base(2865d31) to head(674cb58).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #9486   +/-   ##=======================================  Coverage   88.26%   88.26%           =======================================  Files         417      417             Lines       14413    14414    +1       Branches     4208     4211    +3     =======================================+ Hits        12721    12722    +1  Misses       1372     1372             Partials      320      320
FlagCoverage Δ
unittest88.26% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...ckages/utils/src/eslint-utils/getParserServices.ts94.11% <100.00%> (+0.36%)⬆️
.../utils/src/eslint-utils/parserSeemsToBeTSESLint.ts100.00% <100.00%> (ø)

bradzacher
bradzacher previously approved these changesJul 3, 2024
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldbergJoshuaKGoldberg merged commit103de6e intotypescript-eslint:mainJul 6, 2024
62 of 63 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: RuleContext.parserPath should be string | undefined, not string
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp