In#9339,@JoshuaKGoldberg introduced a regression causing a duplicate import identifier. In a project that consumes@typescript-eslint/eslint-plugin@8.0.0-alpha.38, this causes two TypeScript errors in that file (ifskipLibCheck isfalse), complaining about the duplicate import.

I'm not sure, by the way, why this is not a TS error in the repo itself, but causes a TS error when in thenode_modules of another package.
Should we consider turning onskipLibCheck in this repo?
Also, I did a cursory search and was unable to find any rule ineslint,typescript-eslint oreslint-plugin-import that would allow us to catch issues like these 🙁

remove duplicate import

f20c99d

Copy link

Contributor

typescript-eslintbot commentedJul 1, 2024

Thanks for the PR,@abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 1, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ae2bb65`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6682a0f9b0454e00085328d8
😎 Deploy Preview	https://deploy-preview-9465--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

JoshuaKGoldberg approved these changes

Jul 1, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oops. Thanks for the catch!

Copy link

Member

JoshuaKGoldberg commentedJul 1, 2024

Should we consider turning on skipLibCheck in this repo?

...on or off?

I would be +1 on a followup issue around some kind of end-to-end / integration test to catch these errors, for sure. Good call!

Copy link

ContributorAuthor

abrahamguo commentedJul 1, 2024

oh yes haha, I did mean "turn skipLibCheck off".

Copy link

nx-cloudbot commentedJul 1, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitae2bb65. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

Merge branch 'v8' ofhttps://github.com/typescript-eslint/typescript-…

ae2bb65

…eslint into duplicate-identifier

JoshuaKGoldberg merged commit9dce771 intotypescript-eslint:v8

Jul 1, 2024

62 checks passed

github-actionsbot locked asresolvedand limited conversation to collaborators

Jul 9, 2024

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): remove duplicate import`RuleModuleWithMetaDocs`#9465

fix(eslint-plugin): remove duplicate import`RuleModuleWithMetaDocs`#9465

Uh oh!

Conversation

abrahamguo commentedJul 1, 2024•
edited
Loading

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJul 1, 2024

Uh oh!

netlifybot commentedJul 1, 2024•
edited
Loading

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!