I use the function in isBuiltinSymbolLike.ts to replace similar logic. But I am passing a string 'FunctionConstructor' to a function instead of Function since there is a test case where the symbol name is FunctionConstructor. I am not sure if this is the right thing to do.

YutongZhuuand others added2 commits

June 30, 2024 23:08

re-using logic from builtinSymbolLike in no-implied-eval

6d2d958

Merge branch 'typescript-eslint:main' into main

b3eadd5

Copy link

Contributor

typescript-eslintbot commentedJul 1, 2024

Thanks for the PR,@YutongZhuu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 1, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`346072d`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6682e65ad7e4ca00088553e5
😎 Deploy Preview	https://deploy-preview-9462--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJul 1, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit346072d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

YutongZhuu changed the title~~Chore(eslint-plugin): re-using logic from builtinSymbolLike in no-implied-eval~~chore(eslint-plugin): re-using logic from builtinSymbolLike in no-implied-eval

Jul 1, 2024

Copy link

codecovbot commentedJul 1, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base(2865d31) to head(346072d).

Additional details and impacted files

@@           Coverage Diff           @@##             main    #9462   +/-   ##=======================================  Coverage   88.26%   88.26%           =======================================  Files         417      417             Lines       14413    14406    -7       Branches     4208     4205    -3     =======================================- Hits        12721    12716    -5  Misses       1372     1372+ Partials      320      318    -2