Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(typescript-estree): exposes ProjectService logs through the plugin#9337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

higherorderfunctor
Copy link
Contributor

@higherorderfunctorhigherorderfunctor commentedJun 11, 2024
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Exposes the following logs populated byProjectService.

typescript-eslint:typescript-estree:tsserver:errtypescript-eslint:typescript-estree:tsserver:infotypescript-eslint:typescript-estree:tsserver:perftypescript-eslint:typescript-estree:tsserver:event

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@higherorderfunctor!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 11, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2651587
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/666b69c0b3782300081484a3
😎 Deploy Previewhttps://deploy-preview-9337--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@higherorderfunctorhigherorderfunctor changed the base branch frommain tov8June 11, 2024 22:59
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 11, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit2651587. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This also looks lovely, thanks! Tests and all. I'm happy with it as-is but want to also ping@bradzacher and@jakebailey as FYIs as they've both worked on these areas / might have insights too. ✨

@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneJun 13, 2024
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJune 13, 2024 09:14
@higherorderfunctor
Copy link
ContributorAuthor

higherorderfunctor commentedJun 13, 2024
edited
Loading

This should be good to go. Updated the docs. I did make one small change. I figured it would be better to sendundefined to tsserver instead of a function in case it saves on needing to generate those events.

-    eventHandler: (e): void => {-      logTsserverEvent(e);-    },+    eventHandler: logTsserverEvent.enabled+      ? (e): void => {+          logTsserverEvent(e);+        }+      : undefined,
JoshuaKGoldberg reacted with thumbs up emoji

@JoshuaKGoldbergJoshuaKGoldberg merged commitc170c3d intotypescript-eslint:v8Jun 17, 2024
61 of 62 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the feat/9321-expose-ts-project-service-logs branchJune 17, 2024 12:53
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Enhancement(typescript-estree): expose ProjectService logs through plugin
3 participants
@higherorderfunctor@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp