Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(types): allow ProjectServiceOptions for projectService#9318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJun 10, 2024•
edited
Loading

PR Checklist

Overview

Adds in the missing| ProjectServiceOptions to thetypes package'sParserOptions. That necessitates taking in theProjectServiceOptions into thetypes package.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 10, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit12e13b1
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6666f5e3d5f60600083ac945
😎 Deploy Previewhttps://deploy-preview-9318--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 10, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit12e13b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamJune 10, 2024 12:51
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJun 10, 2024
@JoshuaKGoldberg
Copy link
MemberAuthor

Merging this in after only a few hours of1 approval so it gets released today. Normally I'd wait a little longer - someone please yell at me if they have anything they'd want to request changes on!

@JoshuaKGoldbergJoshuaKGoldberg merged commit0f1b064 intotypescript-eslint:v8Jun 10, 2024
69 checks passed
@JoshuaKGoldbergJoshuaKGoldberg added this to the8.0.0 milestoneJun 10, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp