typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore: ensure 'breaking change' label for PRs that touch stable configs#9243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 2 commits intotypescript-eslint:mainfromJoshuaKGoldberg:ci-pr-labels

Jun 4, 2024

Merged

chore: ensure 'breaking change' label for PRs that touch stable configs#9243

bradzacher merged 2 commits intotypescript-eslint:mainfromJoshuaKGoldberg:ci-pr-labels

Jun 4, 2024

Conversation

Copy link

Member

JoshuaKGoldberg commentedJun 4, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesRepo: Require PRs that change config presets to be marked as breaking changes #6890
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Combines:

https://github.com/marketplace/actions/changed-files: to check whether the stable configs were changed
https://github.com/marketplace/actions/require-labels: to require thebreaking change when any stable config was changed

For an example CI failure, seeJoshuaKGoldberg#322 ->JoshuaKGoldberg#322 (comment):

🤖 Beep boop! PRs that change our stable preset configs must be labeled with breaking change.

💖

ci: ensure 'breaking change' label for PRs that touch stable configs

e97b477

Copy link

Contributor

typescript-eslintbot commentedJun 4, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJun 4, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`45d051c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/665e876a66b9210008f12faf
😎 Deploy Preview	https://deploy-preview-9243--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJun 4, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit45d051c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

JoshuaKGoldberg changed the title~~ci: ensure 'breaking change' label for PRs that touch stable configs~~chore: ensure 'breaking change' label for PRs that touch stable configs

Jun 4, 2024

JoshuaKGoldberg requested a review froma team

June 4, 2024 01:00

chore: format

45d051c